This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
refactor Implementation branching into its own module
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
japaric
force-pushed
the
ja-bind-name-server
branch
from
f196ff6
to
811e0ae
Compare
japaric
force-pushed
the
ja-refactor-impl
branch
from
b5cc889
to
eb498e6
Compare
the `start` constructor's parameter list was getting long and we want to add even more configuration options, like EDE, in the future. using the builder pattern lets us introduce new settings without breaking changes
note that because Hickory does not support pre-signed zone files all the DNSSEC tests fail with it
to ensure that hickory-dns is correctly configured to work in NameServer mode
the `start` constructor's parameter list was getting long and we want to add even more configuration options, like EDE, in the future. using the builder pattern lets us introduce new settings without breaking changes
This reverts commit 3731d8e.
the `start` constructor's parameter list was getting long and we want to add even more configuration options, like EDE, in the future. using the builder pattern lets us introduce new settings without breaking changes
support Hickory in the NameServer role
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbefore merging this