-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Group Queues by Category #739
Conversation
} | ||
|
||
public getDescription(): string { | ||
return this.description; | ||
} | ||
|
||
public getCategory(): string { | ||
return (this.category || 'default').toUpperCase(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the uppercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ideia is to normalize the data, otherwise Category 1
and category 1
will be distinct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to remove uppercase here and treat it in another leve, since the category
property at base adapter is public, otherwise getCategory
and class.category
can return different data.
Hi @manfe thank you for the PR.
|
@felixmosh regarding your points.
|
We can discuss the best implementation for UI/UX part. That's work for you @felixmosh ? |
Hi thanks, I'm AFK till Wednesday. |
This PR introduces:
How it works:
Screen.Recording.2024-05-10.at.20.37.57.mov