-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inherited static functions #679
base: master
Are you sure you want to change the base?
Conversation
Hmm, from the tests it really doesn't like that, but from the functionality it works nice :-( |
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
===========================================
+ Coverage 82.17% 82.27% +0.1%
- Complexity 935 940 +5
===========================================
Files 44 44
Lines 2154 2167 +13
===========================================
+ Hits 1770 1783 +13
Misses 384 384
|
Could you explain what this PR fixes? What do you mean with parent contexts? |
eg.
and then when you call |
src/DefinitionResolver.php
Outdated
$name = (string)$className . '::$' . $memberName; | ||
} else { | ||
$name = (string)$className . '::' . $scoped->memberName->getText($scoped->getFileContents()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of logic here that does not change on each loop iteration, such as the instanceof
checks above and the member name. Could you save this in variables and move it out of the loop?
Also, could you add a test? |
They are tested as references to the TestClass
Hi, |
When the resolveScopedPropertyAccessExpressionNodeToFqn cannot find the definition, try it the extended class