Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pkgbuild #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coquizen
Copy link
Contributor

@coquizen coquizen commented Aug 1, 2019

In order to maintain directory-name consistency with /usr/share/lightdm-webkit/themes, I changed the install directory to /usr/share/lightdm-webkit/themes/iskra instead of /usr/share/lightdm-webkit/themes/iskra-webkit-greeter. This necessitated path changes at points in various other files. Furthermore, I amended a typo in the .gitignore, amended engine=lightdm-webkit-greeter to the more appropriate engine=lightdm-webkit2-greeter. I have also drafted a PKGBUILD file for AUR packaging.

May I suggest changing the name of the git repository to lightdm-webkit2-theme-iskra to maintain naming consistency with other lightdm-webkit2 themes? If you choose to do so, the PKGBUILD needs to be updated accordingly.

@felipemarinho97
Copy link
Owner

Thank you for the contribution @CaninoDev !
The PKGBUILD addition is super useful!

But, why did you rename session=gnome to session=xfce4?

@coquizen
Copy link
Contributor Author

coquizen commented Aug 7, 2019

Oh whoops.. That is an oversight on my part (I only have XFCE4 installed and specified XFCE as the default session.

@felipemarinho97
Copy link
Owner

Okay, in fact, gnome also is not my default session, but it is like this in the file because it's probably the most used..
Also, did you intend to be the maintainer of this PKGBUILD on AUR? the available release is very old and maybe I'll make another release with the most latest changes

@coquizen
Copy link
Contributor Author

coquizen commented Aug 7, 2019

I can volunteer to be the maintainer of the AUR package. When do you think we can expect the new release?

@coquizen
Copy link
Contributor Author

coquizen commented Aug 7, 2019

Also how would you like to license git? GPL? MIT?

@felipemarinho97
Copy link
Owner

@CaninoDev Nice! =D
I will release in less than 1 week, probably this weekend.. you can license it on GPL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants