Feat/create fleets error handling (#30)

* chg: fix: add error handling for create fleets errors

* chg: docs: add note about account validation

CREATING.md

@@ -29,6 +29,9 @@ See the [Recommended AMIs](#recommended-amis) section for more information.
 
 For all the available options, run `dev-spaces create --help`. Also, see the [Command Parameters](#command-parameters) section for more information.
 
+> **Note**
+If you are using your AWS account for the first time, it is possible that the first attempt fail on "CreateFleet" because the AWS is performing additional validation on your account. You should receive an email from AWS informing you about this. If that happens, just try again after a few minutes.
+
 Once created, you can use the command `dev-spaces start` to start the space.
 
     $ dev-spaces start -n MyAmazonLinux2023 -c 1 -m 1 --wait

cli/commands/create.go

@@ -76,6 +76,8 @@ func CreateCommand(c *cli.Context) error {
 		if strings.Contains(err.Error(), "already exists") {
 			log.Warn(fmt.Sprintf("DevSpace \"%s\" already exists.", name))
 			return err
+		} else {
+			DestroyCommand(c)
 		}
 		return err
 	}

core/create.go

@@ -145,10 +145,10 @@ func (h *Handler) Create(ctx context.Context, opts CreateOptions) (CreateOutput,
 	}
 	log.Info(fmt.Sprintf("Spot task created: %s - Waiting instance to be assigned..", *taskRunner.FleetId))
 	id, err := helpers.WaitForFleetInstance(ctx, client, *taskRunner.FleetId, types.InstanceStateNameRunning)
-	log.Info(fmt.Sprintf("Instance assigned: %s", id))
 	if err != nil {
 		return CreateOutput{}, err
 	}
+	log.Info(fmt.Sprintf("Instance assigned: %s", id))
 
 	// get the volume id associated with the instance
 	instanceData, err := helpers.GetInstanceData(ctx, client, id)

core/helpers/instance.go

@@ -103,5 +103,23 @@ func WaitForFleetInstance(ctx context.Context, client clients.IEC2Client, reques
 			}
 
 		}
+
+		// get fleet history
+		out3, err := client.DescribeFleetHistory(ctx, &ec2.DescribeFleetHistoryInput{
+			FleetId:   &requestID,
+			StartTime: aws.Time(time.Now().Add(-24 * time.Hour)),
+		})
+		if err != nil {
+			continue
+		}
+
+		if len(out3.HistoryRecords) > 0 {
+			// iterate over history records, if there is a record with a status of error, return error and print error message
+			for _, record := range out3.HistoryRecords {
+				if record.EventType == "error" && record.EventInformation.EventDescription != nil {
+					return "", fmt.Errorf("error creating instance: %s", *record.EventInformation.EventDescription)
+				}
+			}
+		}
 	}
 }