refactor(fresh_graphql): remove http dependency #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The current API is consistent with fresh_dio and since http is already a transitive dependency it seems harmless to leave it as is so that folks who want to use the provided http client can do so. If you feel strongly I'm happy to discuss further but it doesn't seem worth making the breaking change imo 🤷 |
|
Closing this for now but happy to continue the discussion 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fresh_graphqlhashttpas a dependency but it is not always used. We can safely removehttpdependency and let user decide to choose eitherdioorhttp.