Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addnoscript#889 #1102

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Ayesh-07
Copy link
Contributor

@Ayesh-07 Ayesh-07 commented Mar 8, 2024

What does this change do?

git commit --signoff on amending my commit.

Fixes: #889

How should we test your change?

Checklist for Submitter

  • Added a changelog fragment
  • Added or updated other documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached for UI changes
  • Have db migrations been tested, if there are any?

@gridhead gridhead requested review from abompard and gridhead March 8, 2024 15:12
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayesh-07, the commits are still not signed and hence, DCO won't pass.

Please read up on how we verify contributions.

@Ayesh-07 Ayesh-07 requested a review from gridhead March 10, 2024 06:37
Signed-off-by: Ayesh-07 <[email protected]>
Signed-off-by: Ayesha Nudrat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a noscript tag to index.html for browsers with Javascript disabled
2 participants