Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Reuse for the license #422

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use Reuse for the license #422

wants to merge 2 commits into from

Conversation

olamidepeterojo
Copy link

Fixes #383

abompard
abompard requested changes Dec 17, 2024
View reviewed changes
fedora_messaging/__init__.py Outdated
# You should have received a copy of the GNU General Public License along
# with this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is C/Javascript-style comments. In Python comments start with a #.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, i will amend it.

fedora_messaging/__init__.py Outdated
/*
* SPDX-FileCopyrightText: 2024 Red Hat, Inc
*
* SPDX-License-Identifier: GPL-3.0-or-later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license is actually GPL-2.0-or-later.

Copy link
Author

@olamidepeterojo olamidepeterojo Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, although someone asked what version of GPL you preferred and you said GPL-3.0-or-later, that's why i made use of it .
so which do you prefer i make use of?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change the license from what it was before, even though I would prefer GPL-3.0-or-later, the code is currently under GPL-2.0-or-later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll update it to GPL-2.0-or-later.

abompard
abompard requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is lacking the Reuse check itself. You can for example use this block in .pre-commit-config.yml :

  - repo: https://github.com/fsfe/reuse-tool
    rev: v5.0.2
    hooks:
      - id: reuse

docs/sample_schema_package/mailman_messages/__init__.py
@@ -2,7 +2,7 @@
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# the Free Software Foundation; either version 3 of the License, or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still changing the license. By the way, if you start using the SPDX-License-Identifier tag, you can drop this block of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abompard abompard abompard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Reuse for the license
2 participants
@olamidepeterojo @abompard