vite 2.7.0 warning fix by using conditional exports #614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vite 2.7.0 users are getting
@feathersjs/vuex is incorrectly packaged. Please contact the package author to fix.
vitejs/vite#6013
This provides a fix by declaring that we export ESM. The main is still technically incorrect, but that's harder to fix as we use Typescript and they haven't released Node Native ESM support as of TS 4.5.
The same fix works on 4.0.1-pre.7, which someone forgot to tag in GH
Sandbox
https://stackblitz.com/edit/feathersjs-wy4w68?file=vuex-package.json
Risks
Alternative solutions
.mjs
Sources
https://nodejs.org/api/packages.html#conditional-exports