fix getId to also check for props on the prototype

The `getId` check would fail if the `id` property was in somewhere in the prototype chain. This updates `getId` to also check the prototype properties.
feathersjs-ecosystem · Oct 23, 2019 · 101a7d3 · 101a7d3
1 parent c7af6fa
commit 101a7d3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -184,13 +184,13 @@ export function getId(item, idField) {
   if (!item) {
     return
   }
-  if (item.hasOwnProperty('id')) {
+  if (item.id != null || item.hasOwnProperty('id')) {
     return item.id
   }
-  if (item.hasOwnProperty('_id')) {
+  if (item._id != null || item.hasOwnProperty('_id')) {
     return item._id
   }
-  if (item.hasOwnProperty(idField)) {
+  if (item[idField] != null || item.hasOwnProperty(idField)) {
     return item[idField]
   }
 }