Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve api doc #71

Merged
merged 4 commits into from
Oct 30, 2024
Merged

refactor: improve api doc #71

merged 4 commits into from
Oct 30, 2024

Conversation

andylokandy
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
src/append/mod.rs Outdated Show resolved Hide resolved
src/append/mod.rs Outdated Show resolved Hide resolved
src/filter/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@andylokandy andylokandy enabled auto-merge (squash) October 30, 2024 14:26
@andylokandy andylokandy merged commit 2a69e10 into fast:main Oct 30, 2024
5 checks passed
@tisonkun
Copy link
Contributor

Let me release a 0.15.1 for this. We don't introduce any API changes, do we?

#[derive(Default, Debug, Clone)]
pub struct JsonLayout {
pub tz: Option<TimeZone>,
tz: Option<TimeZone>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. This is one. Then let me release a 0.16.0

/// })
/// .apply();
/// ```
pub fn filter(mut self, filter: impl Into<Filter>) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one.

@andylokandy andylokandy deleted the api branch October 30, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants