feat: support setting global max_level #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
commented
Oct 9, 2024
| @@ -192,7 +204,6 @@ impl log::Log for Logger { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(tisonkun): logback and log4j2 support custom error handling (status listener). | |||
There was a problem hiding this comment.
@andylokandy I finally tend not to add something like ErrorListener or StatusListern for customizing error handling.
The current hard code behavior works well and I don't find any other way to "customize" it. If there is some real requirement (and it's always doable), we can add it later, instead of providing a public interface at this point.
tisonkun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.