Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on iOS #13

Closed
wants to merge 2 commits into from
Closed

Working on iOS #13

wants to merge 2 commits into from

Conversation

coreyar
Copy link

@coreyar coreyar commented Sep 30, 2020

Description

Updates the project to run on ios

  • Renames font-files so the names are consistent across both platforms
  • Disables flipper so that use-frameworks can be used with react-native-file-selector Issue
  • Creates a constants for font families

@coreyar
Copy link
Author

coreyar commented Sep 30, 2020

I opened this PR as a draft because I am currently unable to test on Android. It appears that the project requires JVM 11 and I currently have 14 installed.

@farshed Can you let me know what version of java you are using so I can try to narrow down the issue?

@farshed
Copy link
Owner

farshed commented Sep 30, 2020

Nice work @coreyar. You should know that I'm working on a custom file system interface (based on react-native-fs) that would allow us to not be dependant on react-native-file-selector anymore. Btw, I'm on version 8 of Java and Android doesn't support higher Java versions afaik

@coreyar
Copy link
Author

coreyar commented Sep 30, 2020

@farshed would you like to take this PR in the meantime so other iOS issues could be ironed out or should I close it?

@farshed farshed marked this pull request as ready for review September 30, 2020 12:41
@coreyar
Copy link
Author

coreyar commented Sep 30, 2020

Also, you can build Android apps on versions of Java greater than 8. I believe 8 is the minimum. I currently use 14 for other RN Android apps. I believe it comes down to the gradle setup

@coreyar coreyar closed this Feb 8, 2022
@coreyar coreyar deleted the runs-on-ios branch February 8, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants