This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Change background color from black to white index.html #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is meant to fix farooqkz#36
Change background color from black to white index.html
|
@plan5 Thank you for your contribution! I am gonna test this on my own device(Nokia 800 Tough) and invite people to test it to make sure it's fine. |
|
I've tested on my device and there is a problem. The status bar is totally white and therefore the stuff in there cannot be seen. I have to investigate on this further. But I think it has to do something either with an entry in
|
The "false" part wasn't properly compiled as a string, leaving only the autoPlay part. Removing the entire attribute falls back on the default, which is no autoplay. Before, all audio messages started playing once they were loaded into the RoomView.
Fix audio messages
|
The same problem exists in this PR of yours. You have mixed again. |
|
This is weird. These commits were added when I created #93 it seems to me. As this PR turned out to be more of a workaround than a fix anyway, I'll close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix #36
On Nokia 8000 4G, this fixes the issue of unfocused messages in RoomView being unreadable due to black text on black background setting. Quick tests with Nokia 8110 showed no issues.