Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(WIP): Rewrite resolver #600

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

refactor(WIP): Rewrite resolver #600

wants to merge 65 commits into from

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Oct 1, 2023

Description:
see detail #525
close #525
close #494

BREAKING CHANGE:

Related issue (if exists):

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2023

⚠️ No Changeset found

Latest commit: 527f46e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ErKeLost ErKeLost added enhancement New feature or request RFC roadmap roadmap refactor refactor some feature labels Oct 1, 2023
@ErKeLost ErKeLost removed the RFC label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #600 (d695c06) into main (290cf1c) will decrease coverage by 1.49%.
Report is 45 commits behind head on main.
The diff coverage is 67.74%.

❗ Current head d695c06 differs from pull request most recent head 527f46e. Consider uploading reports for the commit 527f46e to get more accurate results

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   80.54%   79.06%   -1.49%     
==========================================
  Files         153      153              
  Lines       20753    20201     -552     
==========================================
- Hits        16715    15971     -744     
- Misses       4038     4230     +192     
Files Coverage Δ
crates/plugin_resolve/src/lib.rs 87.69% <ø> (ø)
crates/plugin_resolve/tests/basic.rs 98.43% <ø> (ø)
crates/plugin_resolve/tests/browser.rs 97.96% <ø> (-0.18%) ⬇️
crates/plugin_resolve/tests/exports.rs 97.12% <97.02%> (-0.08%) ⬇️
crates/plugin_resolve/src/resolver_cache/cache.rs 54.68% <54.68%> (ø)
crates/plugin_resolve/src/resolver/mod.rs 87.65% <88.63%> (ø)
crates/plugin_resolve/src/resolver_common/mod.rs 32.48% <32.48%> (ø)

... and 51 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor refactor some feature roadmap roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: Rewrite resolver [Bug] farm incorrect resolve dependency
1 participant