Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/partial bundling #532

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

shulandmimi
Copy link
Member

@shulandmimi shulandmimi commented Aug 30, 2023

Description:

See RFC-003

BREAKING CHANGE:
Configuration partialBundling.moduleBuckets will be removed, and other two new options will be added instead.

Related issue (if exists):

#463

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

🦋 Changeset detected

Latest commit: 3bb3be1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farmfe/plugin-webpack-partial-bundling Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wre232114 wre232114 added feature New feature request WIP Working in progress labels Aug 31, 2023
@wre232114
Copy link
Member

I think following designs can be optimized:

  1. We have already designed mutable/immutable modules so default configuration like vendors is not needed any more.
  2. We do not split but do merge, see RFC-003

@shulandmimi shulandmimi marked this pull request as ready for review November 4, 2023 16:11
@shulandmimi shulandmimi force-pushed the refactor/partial-bundling branch 3 times, most recently from 83fc062 to a6ce5e4 Compare November 8, 2023 04:00
@shulandmimi shulandmimi requested review from wre232114 and removed request for wre232114 November 8, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request WIP Working in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants