Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redesign resolvedConfig #1926

Open
wants to merge 7 commits into
base: v2-dev
Choose a base branch
from

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Nov 7, 2024

Action

Existing code issues

1. Long methodological issues

The resolveConfig method is too long, its responsibilities are too scattered, and it is difficult to understand and maintain.

2. having a high degree of coupling

The method handles multiple different tasks internally, such as environment variable setting, configuration file loading, plug-in parsing, etc., resulting in tight coupling of the various parts.

3. Insufficient readability

There is a lack of adequate annotations, variable naming is not intuitive enough, and the logical flow is not clear enough.

4. Logic complex

Some logics are mixed together, making it difficult to track the execution order and conditional judgment.

optimization scheme

writing...

Action

options change

1. add mode in inlineOptions

2. remove configPath options in inlineOptions

3. The logic of integrating server config is disassembled and put into the server creation, so that different operations can be done for different situations

4. The logic of integrating previewServer config is disassembled and put into the previewServer creation, so that different operations can be done for different situations

writing...

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 037aa62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "farm-docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ErKeLost ErKeLost changed the title refactor: Redesign resolvedConfig refactor: redesign resolvedConfig Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant