refactor: redesign resolvedConfig #1926
Open
+23
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action
Existing code issues
1. Long methodological issues
The resolveConfig method is too long, its responsibilities are too scattered, and it is difficult to understand and maintain.
2. having a high degree of coupling
The method handles multiple different tasks internally, such as environment variable setting, configuration file loading, plug-in parsing, etc., resulting in tight coupling of the various parts.
3. Insufficient readability
There is a lack of adequate annotations, variable naming is not intuitive enough, and the logical flow is not clear enough.
4. Logic complex
Some logics are mixed together, making it difficult to track the execution order and conditional judgment.
optimization scheme
writing...
Action
options change
1. add
mode
ininlineOptions
2. remove
configPath
options ininlineOptions
3. The logic of integrating server config is disassembled and put into the server creation, so that different operations can be done for different situations
4. The logic of integrating previewServer config is disassembled and put into the previewServer creation, so that different operations can be done for different situations
writing...