fix: on conflict criteria is ambiguous and cannot be used for upsert #2197
Conversation
🦋 Changeset detectedLatest commit: 8c0b0e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -62,28 +62,35 @@ export class MessageProcessor { | |||
| ...opData, | |||
| }) | |||
| .returning(["id"]) | |||
| .onConflict((oc) => | |||
| oc | |||
| .columns(["hash", "fid", "type"]) | |||
There was a problem hiding this comment.
If I'm understanding the issue correctly, we could have probably replaced this line with .columns(["hash"]) and solved the problem, but this approach is perhaps more comprehensive (though it's impossible to have a conflict on hash-fid-type without also having a conflict on hash).
That said, I suppose it's technically the case that we allow two messages to have the same hash as long as they are of different types and/or from different FIDs.
There was a problem hiding this comment.
the problem is that postgres seems to handle it ambiguously when there's two conflict conditions, but you cannot bifurcate or aggregate conflict handlers. seems odd since they allow where clauses in the conflict scope
Why is this change needed?
Shuttle defines the messages table with two unique constraints, one for the hash, another for the triple of hash, fid and type. Postgres does not allow multiple ON CONFLICT criteria, and ambiguous conflicts are essentially surfaced as uniqueness violation failures in spite of ON CONFLICT criteria given. This change alters the merge to instead attempt insert, doing nothing on any conflict, then resolving with an update if necessary and the original conflict resolution criteria is satisfied.
Addresses Issue #2167
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewPR-Codex overview
This PR updates the conflict resolution logic in
MessageProcessorto fix ambiguity issues during upsert operations.Detailed summary
doNothing()method instead of complex conditions