Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Conan badge as a proper listing in a registry #369

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

mattkretz
Copy link
Contributor

conan.io is listed as an awesome research software registry: https://github.com/NLeSC/awesome-research-software-registries

Adjust tests and expected test output.

Checklist

  • Code follows the contributing guidelines of the project
  • This PR solves an existing issue and provided solution was discussed
  • The fix has been locally tested
  • Code follows the project's coding standards
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • The documentation has been updated to reflect the new feature

List of related issues or pull requests

Briefly describe the changes made in this pull request

Recognize Conan badge as proper software registry.

Additional Notes

@c-martinez ping

Instructions to review the pull request

Execute pytest as documented in the README. https://github.com/mattkretz/vir-simd is an example repo with Conan badge.

conan.io is listed as an awesome research software registry:
https://github.com/NLeSC/awesome-research-software-registries

Adjust tests and expected test output.
@c-martinez c-martinez self-requested a review October 8, 2024 20:47
Copy link
Contributor

@c-martinez c-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this PR works fine and could be merged.

@fdiblen -- don't know if you would like someone to double check? Otherwise, I think this could be merged.

Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution, @mattkretz!
I will merge it to avoid any further delays.

@fdiblen fdiblen merged commit c7dc670 into fair-software:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants