-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lingering progressbar text #81
base: main
Are you sure you want to change the base?
Conversation
I tried to clear it as well in #48, but was not successful. This branch for my bash shell (on Linux Mint 20.1) looks like clear;reset
(env) verhoes@slurper ~/git/fair-software/fairtally $ fairtally https://github.com/fair-software/fairtally
fairtally progress: |████████████████████████████████████████████| 1/1
Completed fairtally on 1 URLs and written report to tally.html
(env) verhoes@slurper ~/git/fair-software/fairtally $ lly.html Having |
889514d
to
e56710c
Compare
Co-authored-by: Stefan Verhoeven <[email protected]>
I fiddled with it some more, to no avail. I get the feeling we're missing something, but in the meantime, I've committed your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same feeling, something is not being reset/cleared correctly.
However this is better then before.
Now initializing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for small URLs
(env) verhoes@slurper ~/git/fair-software/fairtally $ fairtally https://github.com/fair-software/fairtally
fairtally progress: |████████████████████████████████████████████| 1/1
Completed fairtally on 1 URLs and written report to tally.html
(env) verhoes@slurper ~/git/fair-software/fairtally $
However for long URL fails with URL not being cleaned up completely
(env) verhoes@slurper ~/git/fair-software/fairtally $ fairtally https://github.com/fair-software/fairtallygfdgdgdfgdfvbhslbvsljkhbjlhdbvjlhsd
fairtally progress: |████████████████████████████████████████████| 1/1
Completed fairtally on 1 URLs and written report to tally.htmlfdgdgdfgdfvbhslbvsljkhbjlhdbvjlhsd
(env) verhoes@slurper ~/git/fair-software/fairtally $
OK, I give up :( I'll revert the changes when I got a moment |
Refs #80
output should now look like this (no lingering text)