-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve expand button and styling #56
base: main
Are you sure you want to change the base?
Conversation
Show expand button only when it is necessary Adjust alignment (center everything except url) Always show sorting arror Adjust header font Adjust body font Adjust icon sizes Smaller font size for stdout and stderror Show expand button only if there is stderr or stdout Show stderr and stdout only when they exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verifed that expand button has moved and is only shown when stderr|stdout is truthy, good job
When expanded the collapse button moves out of screen. Can a scrollbar be added to the stdout/stderr div?
Showing the sort icons always is confusing to me. Which column is it sorted on now is not clear. Can the icons of non-sorted colums be hidden or grayed out?
}, { | ||
name: 'expand', | ||
required: true, | ||
label: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can log
be used as text inside the header?
Co-authored-by: Stefan Verhoeven <[email protected]>
Refs: #44 #45
Changes
How to test
Example file content:
fairtally --input-file rsd-urls.txt
tally.html
with the screenshot belowScreenshot