Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve expand button and styling #56

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve expand button and styling #56

wants to merge 3 commits into from

Conversation

fdiblen
Copy link
Member

@fdiblen fdiblen commented Mar 5, 2021 •
edited
Loading

Refs: #44 #45

Changes

  • Show expand button only when it is necessary
  • Adjust alignment (center everything except url)
  • Always show sorting arror
  • Adjust header font
  • Adjust body font
  • Adjust icon sizes
  • Smaller font size for stdout and stderror
  • Show expand button only if there is stderr or stdout
  • Show stderr and stdout only when they exist

How to test

  1. Add some urls to a txt file
    Example file content:
https://github.com/SCM-NV/qmflows
https://github.com/3D-e-Chem/sygma
https://github.com/3D-e-Chem/3D-e-Chem-VM
https://github.com/NLeSC/ahn-pointcloud-viewer-ws
https://github.com/NLeSC/ahn-pointcloud-viewer
https://github.com/nlesc-ave/ave-rest-service
  1. Run fairtally
    fairtally --input-file rsd-urls.txt
  2. Compare tally.html with the screenshot below

Screenshot
image

@fdiblen
Move expand button
2c290d5 
Show expand button only when it is necessary
Adjust alignment (center everything except url)
Always show sorting arror
Adjust header font
Adjust body font
Adjust icon sizes
Smaller font size for stdout and stderror
Show expand button only if there is stderr or stdout
Show stderr and stdout only when they exist
@fdiblen fdiblen changed the title Move expand button Improve expand button and styling Mar 5, 2021
@fdiblen fdiblen changed the title Improve expand button and styling 44-45-Improve expand button and styling Mar 5, 2021
@fdiblen fdiblen added the standup label Mar 5, 2021
sverhoeven
sverhoeven requested changes Mar 8, 2021
View reviewed changes
Copy link
Member

@sverhoeven sverhoeven left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verifed that expand button has moved and is only shown when stderr|stdout is truthy, good job

When expanded the collapse button moves out of screen. Can a scrollbar be added to the stdout/stderr div?

Showing the sort icons always is confusing to me. Which column is it sorted on now is not clear. Can the icons of non-sorted colums be hidden or grayed out?

fairtally/data/index.html.template
}, {
name: 'expand',
required: true,
label: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can log be used as text inside the header?

fairtally/data/index.html.template Outdated Show resolved Hide resolved
@fdiblen fdiblen removed the standup label Mar 8, 2021
@fdiblen fdiblen marked this pull request as draft March 8, 2021 09:51
@jspaaks jspaaks changed the title 44-45-Improve expand button and styling Improve expand button and styling Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverhoeven sverhoeven sverhoeven requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdiblen @sverhoeven