Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same as PR24 but with reporting as vue app instead of jinja #25

Merged
merged 6 commits into from
Mar 3, 2021
Merged

Same as PR24 but with reporting as vue app instead of jinja #25

merged 6 commits into from
Mar 3, 2021

Conversation

jspaaks
Copy link
Member

@jspaaks jspaaks commented Mar 1, 2021 •
edited
Loading

First merge PR #24

includes sorting by url, count, and badge (refs #7)

Should also fix #26

@sverhoeven sverhoeven mentioned this pull request Mar 1, 2021
Closed
@jspaaks jspaaks mentioned this pull request Mar 3, 2021
Merged
sverhoeven
sverhoeven approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We can make it better in new PRs

@sverhoeven sverhoeven marked this pull request as ready for review March 3, 2021 13:31
@eriktks eriktks merged commit 2142150 into main Mar 3, 2021
@eriktks eriktks deleted the 7-sort branch March 3, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include HTML template in distribution
3 participants
@jspaaks @sverhoeven @eriktks