Enhance Data Retrieval Accuracy with MatchType in TimeseriesRef #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
look at CI... |
- Added an enumeration MatchType with options Exact and Nearest. - Modified atTime and getRawIndexAtTime in TimeseriesRef to support MatchType, allowing callers to specify whether they need an exact timestamp match or the nearest available match. - Adjusted the atTime method to throw an error when an exact match is required but not found, enhancing error handling for strict match requirements.
|
I have resolved the compilation issues. However, I have a question regarding the proposal to pass an enum class |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (match_type == MatchType::Exact) | ||
| { | ||
| auto it = std::find_if(_plot_data->begin(), _plot_data->end(), | ||
| [t](const auto& point) { return point.x == t; }); |
Check notice
Code scanning / CodeQL
Equality test on floating-point values Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduces the
MatchTypeenumeration toTimeseriesRef, providing the option to choose between exact and nearest time matching. Changes include updates to theatTimeandgetRawIndexAtTimemethods to support this new functionality.For a detailed problem description see: #968