ci: fixes macOS builds #1019
Open
ci: fixes macOS builds #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Ramon! |
|
Thanks, but all the other builds are failing (see CI) |
|
seems the touch ups with protobuf are failing. I will take a look. |
It should be ok now. |
mrpollo
commented
Nov 18, 2024
| @@ -118,7 +120,7 @@ export LDFLAGS="$QT_HOME/lib" | |||
| Clone the repository into **~/plotjuggler_ws**: | |||
|
|
|||
| ```shell | |||
| git clone https://github.com/facontidavide/PlotJuggler.git ~/plotjuggler_ws/src/PlotJuggler | |||
| git clone https://github.com/PX4/PlotJuggler.git ~/plotjuggler_ws/src/PlotJuggler | |||
| @@ -10,24 +10,24 @@ endif() | |||
| find_package(ZeroMQ QUIET) | |||
|
|
|||
| if(ZeroMQ_FOUND) | |||
| message(STATUS "[ZeroMQ] found") | |||
| # message(STATUS "[ZeroMQ] found") | |||
There was a problem hiding this comment.
can you please cleanup comments?
There was a problem hiding this comment.
what is going on here?
Are you intentionally removing ZeroMQ plugin?
mrpollo
force-pushed
the
main
branch
5 times, most recently
from
ed79ea6 to
dc9cb8c
Compare
|
@facontidavide we made a few changes can you please approve the workflow runs? thank you |
farhangnaderi
force-pushed
the
main
branch
3 times, most recently
from
085c880 to
b1ad089
Compare
ci: Fixes macOS builds (#1) adds runners for both Intel and Apple silicon macs --------- Co-authored-by: Daniel Agar <[email protected]> Co-authored-by: Ramon Roche <[email protected]>
|
I rebased and seems on local repo it passed all CI checks! |
facontidavide
requested changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the macOS CI