add build for Python 3.12

[Mon-ius]

updated the CI for conda and wheel build for Python 3.12, as requested in #1016 (comment). 🤗

[facebook-github-bot]

Hi @Mon-ius!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.73%. Comparing base (3fea61a) to head (7a01a24).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   60.72%   60.73%   +0.01%     
==========================================
  Files         113      113              
  Lines        9786     9786              
==========================================
+ Hits         5943     5944       +1     
+ Misses       3843     3842       -1     

Flag	Coverage Δ
Python	60.73% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danthe3rd]

Thanks! Unfortunately the main issue here is that we are running out of storage on anaconda, and won't have space to store extra versions :/
Hopefully we can manage to significatively reduce binary size soon and support all recent python versions

[Mon-ius]

Never thought it would be an issue, if that's possible to publish to pypi only?

I have revoke the python bump of 3.11 and 3.12 in .github/workflows/conda.yml, and keep only .github/workflows/wheels.yml for PyPI for Py312 for your concern 🤗

[danthe3rd]

How do you install xFormers? Do you install it with the --index-url https://download.pytorch.org/whl/cuXXX part in the pip install command?
If so, we don't have any space problem. We might want to store all Python versions there, and only a limited subset in pypi

[Mon-ius]

we have two env setup solutions for xformer installation from conda and pip, but the conda one started not work due to the version issue, that's why I am here for subimit the PR 🤗

[danthe3rd]

conda is usually the better solution, but they also have the lowest storage (~10GB). We were able to negociate 20GB for pypi - trying to push it further now.
The only real solution we have is to host on the Meta servers for PyTorch for pip - which are used when you specify --index-url https://download.pytorch.org/whl/cu121 in pip

[Mon-ius]

If it is possible to increase the storage on Conda, that would be ideal. Otherwise, there will always be a compromising solution.

[danthe3rd]

I'm working on getting py3.12 support for pip wheels (at least on the PyTorch s3) - hopefully we can enable that soon :)

[Remember2015]

any updates?
when I use pip install xformers --index-url=https://download.pytorch.org/whl/cu121
it seems not work:

Looking in indexes: https://download.pytorch.org/whl/cu121
ERROR: Could not find a version that satisfies the requirement xformers (from versions: none)
ERROR: No matching distribution found for xformers

• python=3.12.3
• pytorch=2.3.0 (py3.12_cuda12.1_cudnn8.9.2_0)

[danthe3rd]

I didn't get a reply, opened a new issue
pypi/support#4168