Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pytest-snail from dev requirements file #2909

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

remove pytest-snail from dev requirements file #2909

wants to merge 8 commits into from

Conversation

omry
Copy link
Collaborator

@omry omry commented Jun 4, 2024

fixes #2908

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2024
@Jasha10
Copy link
Collaborator

Jasha10 commented Jun 6, 2024

Looks like the test_macos jobs are running into this issue: Homebrew/homebrew-cask#173201

@omry
Copy link
Collaborator Author

omry commented Jun 7, 2024

Yeah. The comments there suggest stale state of some brew packages and offering manual cleanup.
It's not clear to me why adoptopenjdk11 is even installed for us. There is no mention in our circleci config.

@Jasha10 Jasha10 mentioned this pull request Jun 14, 2024
Merged
@Jasha10 Jasha10 mentioned this pull request Jun 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest fails on Windows due to an issue with the pytest-snail plugin that is included in requirements/dev.txt
3 participants
@omry @Jasha10 @facebook-github-bot