-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Bijector #103
Open
vmoens
wants to merge
31
commits into
main
Choose a base branch
from
split_bijector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Split Bijector #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 98.25% 98.29% +0.04%
==========================================
Files 6 6
Lines 229 235 +6
==========================================
+ Hits 225 231 +6
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Open
# Conflicts: # flowtorch/bijectors/base.py # flowtorch/bijectors/compose.py # flowtorch/bijectors/ops/spline.py # tests/test_bijector.py
# Conflicts: # flowtorch/bijectors/coupling.py # flowtorch/bijectors/ops/affine.py # flowtorch/parameters/__init__.py # flowtorch/parameters/base.py # tests/test_bijector.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We introduce the Split Bijector, which allows to split a tensor in half, process one half through a sequence of transformations and normalize the other.
Changes proposed
The new class first splits the tensor, then passes the outputs to the
_param_fn
and then to the transform itself.The introduction of a
_forward_pre_ops
and_inverse_pre_ops
methods is necessary as, in the inverse case, we need to first pass the input through the transform inverse to then pass it through the convolutional layer that will give us the normalizing constants. This breaks the_param_fb(...)
->_inverse(...)
logic, as we need to do something before_param_fn
. As this might be the case for the forward pass too, we introduced a similar_forward_pre_ops
method.Types of changes
Checklist