Make AIT use fp32 accumulation for reduce_3d kernels by default. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47928197 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Jul 31, 2023
…ebookincubator#862) Summary: Pull Request resolved: facebookincubator#862 Use fp32 accumulation by default, only use fp16 if use_fp16_acc == True. Differential Revision: D47928197 fbshipit-source-id: 7d321cbc2371b4bda3011c659690c09002a7f40f
muchulee8
force-pushed
the
export-D47928197
branch
from
75b3712
to
5dd6332
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47928197 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Jul 31, 2023
…ebookincubator#862) Summary: Pull Request resolved: facebookincubator#862 Use fp32 accumulation by default, only use fp16 if use_fp16_acc == True. Reviewed By: chenyang78 Differential Revision: D47928197 fbshipit-source-id: b1ad0e6189583419b2ddf41a2ece35a515151380
muchulee8
force-pushed
the
export-D47928197
branch
from
5dd6332
to
c4c7a3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47928197 |
muchulee8
added a commit
to muchulee8/AITemplate
that referenced
this pull request
Jul 31, 2023
…ebookincubator#862) Summary: Pull Request resolved: facebookincubator#862 Use fp32 accumulation by default, only use fp16 if use_fp16_acc == True. Reviewed By: chenyang78 Differential Revision: D47928197 fbshipit-source-id: 1cc98e5d985ae565ebc4560eaf7cd17f519eb8d9
muchulee8
force-pushed
the
export-D47928197
branch
from
c4c7a3b
to
c28740c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47928197 |
…ebookincubator#862) Summary: Pull Request resolved: facebookincubator#862 Use fp32 accumulation by default, only use fp16 if use_fp16_acc == True. Reviewed By: chenyang78 Differential Revision: D47928197 fbshipit-source-id: 0498edc19fa617ec608e5fd263db104b4c529f2c
muchulee8
force-pushed
the
export-D47928197
branch
from
c28740c
to
c01ed4d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47928197 |
|
This pull request has been merged in b4a4d5b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use fp32 accumulation by default, only use fp16 if use_fp16_acc == True.
Differential Revision: D47928197