Add pass to remove no-op dynamic slices #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47838728 |
ColinPeppler
added a commit
to ColinPeppler/AITemplate
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: facebookincubator#861 ## This diff We add a pass to remove no-op dynamic slices in remove_no_ops.py. We ignore any slices that are also marked as outputs. We simply check the input shape and output shape. We may be able to apply this to other operators, as well. ## Visualization | Before Pass | After Pass |--- | {F1060698386 height = 300} | {F1060698388 height=250px} --- ## Notebooks * prototype code: N3985444 * convert PyTorch model to AIT: N4004077 Reviewed By: muchulee8, chenyang78 Differential Revision: D47838728 fbshipit-source-id: 6478179c09b185fc61c201e687246169a52e9b9d
ColinPeppler
force-pushed
the
export-D47838728
branch
from
76ddd04
to
ecabede
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47838728 |
Summary: Pull Request resolved: facebookincubator#861 ## This diff We add a pass to remove no-op dynamic slices in remove_no_ops.py. We ignore any slices that are also marked as outputs. We simply check the input shape and output shape. We may be able to apply this to other operators, as well. ## Visualization | Before Pass | After Pass |--- | {F1060698386 height = 300} | {F1060698388 height=250px} --- ## Notebooks * prototype code: N3985444 * convert PyTorch model to AIT: N4004077 Reviewed By: muchulee8, chenyang78 Differential Revision: D47838728 fbshipit-source-id: 0ca01dfded52a948367bcbf4572f442ed04de690
ColinPeppler
force-pushed
the
export-D47838728
branch
from
ecabede
to
cbab9d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47838728 |
|
This pull request has been merged in 0f07929. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff
We add a pass to remove no-op dynamic slices in remove_no_ops.py. We ignore any slices that are also marked as outputs. We simply check the input shape and output shape. We may be able to apply this to other operators, as well.
Differential Revision: D47838728