Refactor SimpleDisjointSet in fuse_elementwise to use sets #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `SimpleDisjointSet` used in the `fuse_elementwise` transformation pass is using lists to collect groups of the disjoint nodes. In certain cases, this can lead to a heavy duplication in the node groups resulting in the `fuse_elementwise` pass taking much longer time than it should. This diff refactors the `SimpleDisjointSet` to use sets instead of lists to alleviate the node duplication and the resulting long pass execution. Reviewed By: sgrigory Differential Revision: D47466832 fbshipit-source-id: e0550702cfc492b096dbef2b17109aae5d3d7576
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47466832 |
|
This pull request has been merged in 2cecba2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
SimpleDisjointSetused in thefuse_elementwisetransformation pass is using lists to collect groups of the disjoint nodes. In certain cases, this can lead to a heavy duplication in the node groups resulting in thefuse_elementwisepass taking much longer time than it should.This diff refactors the
SimpleDisjointSetto use sets instead of lists to alleviate the node duplication and the resulting long pass execution.Reviewed By: sgrigory
Differential Revision: D47466832