Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Certbot on AWS EC2 does not support manual challenge #646

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

KunalAggarwal
Copy link

Certbot on AWS EC2 does not support manual challenge tls-sni-01, causes the provision script to break, but can work without it. Removing the standalone challenge.

Problem:
The current provision script passed the argument standalone-supported-challenges which does not work well with AWS EC2 instance and produces the following error and causes the script to break with the following error:

The standalone specific supported challenges flag is deprecated. Please use the --preferred-challenges flag instead.
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Plugins selected: Authenticator standalone, Installer None
Obtaining a new certificate
Performing the following challenges:
Client with the currently selected authenticator does not support any combination of challenges that will satisfy the CA.
Client with the currently selected authenticator does not support any combination of challenges that will satisfy the CA.

Solution:
The fix checks if the instance is an EC2 instance and if yes, it does not supply the manual challenge tls-sni-01 to certbot-auto. This prevents the script from breaking and proceeds perfectly.

…es the provision script to break, but can work without it. Removing the standalone challenge.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

KunalAggarwal and others added 2 commits July 18, 2018 17:38
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants