This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Fixes #588: Level Import: Random ISO Code #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
suggested changes
Apr 24, 2019
| @@ -151,7 +151,7 @@ private static function levelFromRow(Map<string, string> $row): Level { | |||
| foreach ($elements as $level) { | |||
| $title = must_have_string($level, 'title'); | |||
| $type = must_have_string($level, 'type'); | |||
| $entity_iso_code = must_have_string($level, 'entity_iso_code'); | |||
| $entity_iso_code = must_have_string($level, 'entity_iso_code') or await Country::genRandomAvailableCountry()->getIsoCode(); | |||
There was a problem hiding this comment.
revert.
- always use
||instead ofor - this is a syntax error, we can't have
awaitin there. must_have_stringwill always return, there's no case where it returns a "falsy" value, so theor await Country::genRandomAvailableCountry()->getIsoCode();will never be executed.
azjezz
suggested changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.