Allow to record from multiple devices even if they connected at same time #238
Conversation
|
Hi @caiiiycuk! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -20,8 +20,9 @@ | |||
|
|
|||
| class DeviceNameCalculator: | |||
|
|
|||
| def __init__(self, executor=AdbExecutor()): | |||
| def __init__(self, executor=AdbExecutor(), args = []): | |||
There was a problem hiding this comment.
Instead of arbitrary args, I think it would be better if we explicitly had a property for the serial no
Hi. I have a hub of devices that permanently connected. In 0.11.0 it's not possible even to record screenshots in that case. Because DeviceNameCalulator fails to obtain name of device. This simple fix makes
recordcomand work as expected.Btw, I don't like that
runcommand overwrite generated html, if you run it on multiple devices. I don't fix this code because I think that it can be a breaking change for someone infrastracture, but I hope that in future run command will also support multiple devices.