Upgrade publish plugin + Dokka

Summary: Necessary due to Kotlin and Gradle upgrades. This upgrade caused a few doc inconsistencies to become errors so I fixed those as well. The `androidJavadoc` task also is no longer available in `afterEvaluate` so I moved the BUCK file exclusion to a more generic `whenTaskAdded` lambda

Differential Revision: D33961680

fbshipit-source-id: 4637af21aef7392b80bb06766bd648cdbd07d154

core/build.gradle

@@ -40,8 +40,13 @@ android {
 
 afterEvaluate {
   generateReleaseBuildConfig.enabled = false
-  tasks.getByName("androidJavadocs") {
-    exclude '**/BUCK'
+}
+
+tasks.whenTaskAdded {
+  if (it.name == "androidJavadoc") {
+    it.configure {
+      exclude '**/BUCK'
+    }
   }
 }
 

core/src/main/java/com/facebook/testing/screenshot/RecordBuilder.java

@@ -65,9 +65,10 @@ public interface RecordBuilder {
    * Set the maximum number of pixels this screenshot should produce. Producing any number higher
    * will throw an exception.
    *
-   * @param maxPixels Maximum number of pixels this screenshot should produce. <= 0 for no limit.
+   * @param maxPixels Maximum number of pixels this screenshot should produce. Specify zero or a
+   *     negative number for no limit.
    */
-  public RecordBuilder setMaxPixels(long maxPixels);
+  RecordBuilder setMaxPixels(long maxPixels);
 
   /** Finish the recording. */
   void record();

core/src/main/java/com/facebook/testing/screenshot/layouthierarchy/AccessibilityUtil.java

@@ -34,8 +34,8 @@
 
 /**
  * This class provides utility methods for determining certain accessibility properties of {@link
- * View}s and {@link AccessibilityNodeInfoCompat}s. It is porting some of the checks from {@link
- * com.googlecode.eyesfree.utils.AccessibilityNodeInfoUtils}, but has stripped many features which
+ * View}s and {@link AccessibilityNodeInfoCompat}s. It is porting some of the checks from
+ * com.googlecode.eyesfree.utils.AccessibilityNodeInfoUtils, but has stripped many features which
  * are unnecessary here.
  */
 public class AccessibilityUtil {
@@ -127,7 +127,7 @@ public static AccessibilityRole getRole(View view) {
    * Gets the role from a given {@link AccessibilityNodeInfoCompat}. If no role is defined it will
    * return AccessibilityRole.NONE, which has a value of null.
    *
-   * @param node The node to check.
+   * @param nodeInfo The node to check.
    * @return {@code AccessibilityRole} the defined role.
    */
   public static AccessibilityRole getRole(AccessibilityNodeInfoCompat nodeInfo) {

layout-hierarchy-common/build.gradle

@@ -35,8 +35,13 @@ android {
 
 afterEvaluate {
   generateReleaseBuildConfig.enabled = false
-  tasks.getByName("androidJavadocs") {
-    exclude '**/BUCK'
+}
+
+tasks.whenTaskAdded {
+  if (it.name == "androidJavadoc") {
+    it.configure {
+      exclude '**/BUCK'
+    }
   }
 }
 

layout-hierarchy-litho/build.gradle

@@ -35,8 +35,13 @@ android {
 
 afterEvaluate {
   generateReleaseBuildConfig.enabled = false
-  tasks.getByName("androidJavadocs") {
-    exclude '**/BUCK'
+}
+
+tasks.whenTaskAdded {
+  if (it.name == "androidJavadoc") {
+    it.configure {
+      exclude '**/BUCK'
+    }
   }
 }
 

versions.gradle

@@ -31,8 +31,8 @@ ext {
       screenshot : "com.facebook.testing.screenshot:plugin:$screenshotTestVersion",
       kotlin     : "org.jetbrains.kotlin:kotlin-gradle-plugin:${versions.kotlin}",
       versions   : 'com.github.ben-manes:gradle-versions-plugin:0.20.0',
-      publish    : 'com.vanniktech:gradle-maven-publish-plugin:0.14.2',
-      dokka      : 'org.jetbrains.dokka:dokka-gradle-plugin:1.4.30'
+      publish    : 'com.vanniktech:gradle-maven-publish-plugin:0.18.0',
+      dokka      : 'org.jetbrains.dokka:dokka-gradle-plugin:1.6.10'
   ]
 
   deps = [