Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Mark Errored Server Components #31879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Dec 20, 2024

This is similar to #31876 but for Server Components.

It marks them as errored and puts the error message in the Summary properties.

Screenshot 2024-12-20 at 5 05 35 PM

This only looks at the current chunk for rejections. That means that there might still be promises deeper that rejected but it's only the immediate return value of the Server Component that's considered a rejection of the component itself.

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:10pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 20, 2024
@react-sizebot
Copy link

Comparing: 45a720f...2587719

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 511.38 kB 511.38 kB = 91.38 kB 91.38 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.17 kB 516.17 kB = 92.23 kB 92.23 kB
facebook-www/ReactDOM-prod.classic.js = 593.09 kB 593.09 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 583.35 kB 583.35 kB = 102.90 kB 102.90 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +1.75% 103.10 kB 104.90 kB +1.70% 19.55 kB 19.88 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +1.75% 103.22 kB 105.02 kB +1.71% 19.71 kB 20.05 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +1.73% 104.54 kB 106.35 kB +1.62% 19.47 kB 19.78 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +1.71% 105.40 kB 107.21 kB +1.67% 20.11 kB 20.44 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +1.71% 105.71 kB 107.51 kB +1.57% 20.11 kB 20.42 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +1.71% 105.96 kB 107.77 kB +1.64% 20.24 kB 20.57 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +1.68% 107.32 kB 109.12 kB +1.55% 20.43 kB 20.74 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +1.68% 107.51 kB 109.31 kB +1.61% 20.45 kB 20.78 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +1.64% 109.95 kB 111.76 kB +1.52% 20.90 kB 21.22 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +1.62% 111.70 kB 113.51 kB +1.62% 21.23 kB 21.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +1.62% 111.79 kB 113.60 kB +1.62% 21.27 kB 21.61 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +1.60% 112.70 kB 114.50 kB +1.52% 21.16 kB 21.48 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +1.58% 114.03 kB 115.84 kB +1.50% 21.42 kB 21.74 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +1.13% 143.57 kB 145.20 kB +0.90% 33.70 kB 34.00 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js +0.35% 518.22 kB 520.03 kB +0.34% 93.27 kB 93.59 kB

Generated by 🚫 dangerJS against cb1d1c0

Copy link
Collaborator

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: Why is there a space in Server Component in the tooltip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants