CI: enable clang tests (#898)

Summary: Pull Request resolved: facebookincubator/zstrong#898 Reviewed By: malanka Differential Revision: D59065671 fbshipit-source-id: 2a09ae13e1d4c62a7b9a907cca0e911672435ad1
facebook · Jul 3, 2024 · 3dfff8f · 3dfff8f
1 parent 346775d
commit 3dfff8f
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/build/fbcode_builder/getdeps.py b/build/fbcode_builder/getdeps.py
@@ -844,14 +844,20 @@ def run_project_cmd(self, args, loader, manifest):
         # Accumulate the install directories so that the build steps
         # can find their dep installation
         install_dirs = []
+        dep_manifests = []
 
         for m in projects:
             inst_dir = loader.get_project_install_dir_respecting_install_prefix(m)
             install_dirs.append(inst_dir)
+            dep_manifests.append(m)
 
             if m == manifest:
+                ctx = loader.ctx_gen.get_context(m.name)
+                env = loader.build_opts.compute_env_for_install_dirs(
+                    loader, dep_manifests, ctx
+                )
                 dep_munger = create_dyn_dep_munger(
-                    loader.build_opts, install_dirs, args.strip
+                    loader.build_opts, env, install_dirs, args.strip
                 )
                 if dep_munger is None:
                     print(f"dynamic dependency fixups not supported on {sys.platform}")

diff --git a/build/fbcode_builder/manifests/clang b/build/fbcode_builder/manifests/clang
@@ -0,0 +1,5 @@
+[manifest]
+name = clang
+
+[rpms]
+clang15-devel
diff --git a/build/fbcode_builder/manifests/glean b/build/fbcode_builder/manifests/glean
@@ -21,6 +21,9 @@ glog
 folly
 rocksdb
 xxhash
+llvm
+clang
+re2
 
 [build]
 builder = make
@@ -29,13 +32,14 @@ builder = make
 cabal-update
 all
 glass
+glean-clang
 EXTRA_GHC_OPTS=-j4 +RTS -A32m -n4m -RTS
-CABAL_CONFIG_FLAGS=-f-clang-tests -f-hack-tests -f-typescript-tests -f-python-tests -f-dotnet-tests -f-go-tests -f-rust-tests -f-java-lsif-tests -f-flow-tests
+CABAL_CONFIG_FLAGS=-f-hack-tests -f-typescript-tests -f-python-tests -f-dotnet-tests -f-go-tests -f-rust-tests -f-java-lsif-tests -f-flow-tests
 
 [make.install_args]
 install
 
 [make.test_args]
 test
 EXTRA_GHC_OPTS=-j4 +RTS -A32m -n4m -RTS
-CABAL_CONFIG_FLAGS=-f-clang-tests -f-hack-tests -f-typescript-tests -f-python-tests -f-dotnet-tests -f-go-tests -f-rust-tests -f-java-lsif-tests -f-flow-tests
+CABAL_CONFIG_FLAGS=-f-hack-tests -f-typescript-tests -f-python-tests -f-dotnet-tests -f-go-tests -f-rust-tests -f-java-lsif-tests -f-flow-tests
diff --git a/build/fbcode_builder/manifests/llvm b/build/fbcode_builder/manifests/llvm
@@ -0,0 +1,5 @@
+[manifest]
+name = llvm
+
+[rpms]
+llvm15-devel