Skip to content

Commit

Permalink
cit2: cmm: remove a few kernel modules from checklist
Browse files Browse the repository at this point in the history
Summary:
Generally speaking, these modules are removed from checklist because
they don't have to be compiled as modules. For example, we may decide to
compile them into kernel for some reasons in the future.

If we want to test the functionality provided by these modules, then we
should do that in different places. For example, i2c-mux-pca954x needs
to be covered in i2c test (and we've already done that).

Notes: I'm suspecting "crypto_hash" is automatically enabled with ext4
but I'm not quite sure. So let's keep it in the checklist as of now.

Test Plan: cmm CIT passed.

Reviewed By: benwei13

fbshipit-source-id: 9f59f83f64
  • Loading branch information
tao-ren authored and facebook-github-bot committed Aug 19, 2019
1 parent 5ddf795 commit 58c7b48
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions tests2/tests/cmm/test_kernel_module_presence.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,4 @@

class KernelModulePresenceTest(BaseKernelModulePresenceTest, unittest.TestCase):
def set_kmods(self):
self.expected_kmod = [
"gpio_pca953x",
"pfe3000",
"fancpld",
"cmmcpld",
"i2c_dev_sysfs",
"i2c_mux_pca954x",
"ext4",
"mbcache",
"jbd2",
"crypto_hash",
]
self.expected_kmod = ["fancpld", "cmmcpld", "i2c_dev_sysfs", "crypto_hash"]

0 comments on commit 58c7b48

Please sign in to comment.