Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
fan_service.json
for DARWIN platform with the following changes:sensor_service
, then again here, resulting in erroneously low readings. Leave it tosensor_service
to scale sensors.fan6
to ensure thatfan_service
is driving its PWM correctly.Test Plan
Tested on Darwin with Linux kernel 6.4 and CentOS 9.
fan_service
runs correctly, sensor scale is correct and all fan RPMs and LEDs are updated: