-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced retry mechanism & test case added #295
base: main
Are you sure you want to change the base?
Conversation
Hi @fary58! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@fary58 thank you so much for contributing to improve the code quality. could you sign the CLA as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you have changed all the single quotes to double quotes. While the repository is not consistent everywhere, we primarily use single quotes. Could you remove this quote change from the pull request to maintain the current code style and make the review process easier?
Hi,
Yes l I'll make the changes.
Regards
…On Thu, 5 Sep 2024 at 03:32, Shuotian Cheng ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I noticed that you have changed all the single quotes to double quotes.
While the repository is not consistent everywhere, we primarily use single
quotes. Could you remove this quote change from the pull request to
maintain the current code style and make the review process easier?
—
Reply to this email directly, view it on GitHub
<#295 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APQFYHJL62WA3XC6WZA6OU3ZU67CTAVCNFSM6AAAAABNVMNZ4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOBRG4ZTQNBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Improved the retry mechanism in VideoUploadTransferRequestManager with exponential backoff to handle transient errors more effectively.
Integrated unit tests to verify the retry logic and ensure robust error handling during the video upload process.