Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced retry mechanism & test case added #295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fary58
Copy link

@fary58 fary58 commented Sep 5, 2024

Improved the retry mechanism in VideoUploadTransferRequestManager with exponential backoff to handle transient errors more effectively.
Integrated unit tests to verify the retry logic and ensure robust error handling during the video upload process.

@facebook-github-bot
Copy link
Contributor

Hi @fary58!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@stcheng
Copy link
Contributor

stcheng commented Sep 5, 2024

@fary58 thank you so much for contributing to improve the code quality. could you sign the CLA as well?

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you have changed all the single quotes to double quotes. While the repository is not consistent everywhere, we primarily use single quotes. Could you remove this quote change from the pull request to maintain the current code style and make the review process easier?

@fary58
Copy link
Author

fary58 commented Sep 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants