-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump webpack-dev-server to resolve DOS vulnerability #10266
chore: Bump webpack-dev-server to resolve DOS vulnerability #10266
Conversation
Hi @bo-carey! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Going to close this as a possible supply chain attack attempt @bo-carey I'll report your account in 24h to GitHub unless you clearly explain what this PR is about, and explain what is this URL "https://nexus.use1.infra-pure.cloud/" |
@slorber Oh, sorry that is due to my npm settings resolving to my own registry. Completely unintentional. I'll close the PRs and run them again from the default registry. |
I understand the mistake, but can't just trust your words considering the possible harm this PR could do. I'll also ask you to explain what vulnerability is fixed by upgrading what dependency. Please give external links to each 3 vulnerabilities you attempt to fix and give your motivations to get them fixed. How did you find about these vulnerabilities. Otherwise I still have to report you. We just added Socket security to the repo to prevent such possible issues in the future. |
@bo-carey: there's absolutely no need to try to fix these issues. The ones you are fixing are dev dependencies and don't have actual attack vectors. Your bumps are across minor versions which means even if we don't change our package.json, users will automatically get the latest, vuln-free version, and we personally don't care. |
Totally understand. I was just trying to be proactive to help with vulnerabilities marked by snyk, which is what I'm personally using as a security monitor. The vulnerabilities are documented on their site, but I'll link them here for posterity:
I realize that consumers can resolve these issues themselves. Sorry for the misunderstanding! I'll be sure to double check my changes in the future. |
Thanks for the explanations This looks like a legit mistake, I won't report it 👍 Indeed those vulnerabilities are probably not worth to be fixed, unless a proven attack vector exists to exploit them. |
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs