Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Support NDK r21e and r22 #2595

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Support NDK r21e and r22 #2595

wants to merge 7 commits into from

Conversation

R1kk3r
Copy link

@R1kk3r R1kk3r commented Mar 4, 2021

This PR add support for NDK r21e and r22. The NDK r22 comes with some changes related to include paths. The target parameter need to contain the platform level version in order for Clang to be able to locate the includes.

@facebook-github-bot
Copy link
Contributor

Hi @R1kk3r!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rajyengi
Copy link
Contributor

rajyengi commented Mar 8, 2021

@R1kk3r looks like a lot of the CI is still broken, they look like tests related to your change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants