Fix GCC -Wreturn-type warnings

Always return false in PowersetAbstractDomain::contains() and SmallSortedSetAbstractDomain::contains() to avoid a gcc warning. On debug builds, this will instead trigger an assertion failure.
facebook · Dec 11, 2023 · 9f0c12d · 9f0c12d
1 parent 49e71e5
commit 9f0c12d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/include/sparta/PowersetAbstractDomain.h b/include/sparta/PowersetAbstractDomain.h
@@ -235,6 +235,9 @@ class PowersetAbstractDomain
       return this->get_value()->contains(e);
     }
     }
+    SPARTA_ASSERT(false && "unknown AbstractValueKind");
+    // Return false to suppress -Wreturn-type warning reported by gcc
+    return false;
   }
 
   friend std::ostream& operator<<(std::ostream& o, const Derived& s) {

diff --git a/include/sparta/SmallSortedSetAbstractDomain.h b/include/sparta/SmallSortedSetAbstractDomain.h
@@ -167,6 +167,9 @@ class SmallSortedSetAbstractDomain final
       return this->get_value()->contains(e);
     }
     }
+    SPARTA_ASSERT(false && "unknown AbstractValueKind");
+    // Return false to suppress -Wreturn-type warning reported by gcc
+    return false;
   }
 
   friend std::ostream& operator<<(std::ostream& out,