Change default MapKeyInfo #3194
Open
+38
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67413011 |
Summary: As titled. This should negate some logspam. Also change MapKeyInfo fusion to consider nan == nan because previously MapKeyInfo(step, nan) fusing with itself would look like a conflict Reviewed By: saitcakmak Differential Revision: D67412730
Summary: I want to converge around the "step" column name (as we use in the API) as opposed to "steps" -- this may not matter in the long run as we rethink mapdata, but I think now is the time to do it. cc ltiao who has diffs in flight that may be effected by this. Lets see if this breaks anything -- shouldnt actually be used anywhere except maybe tests. Differential Revision: D67413011
mpolson64
force-pushed
the
export-D67413011
branch
from
d58414c to
640a88b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67413011 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
==========================================
- Coverage 95.86% 95.86% -0.01%
==========================================
Files 510 510
Lines 51499 51499
==========================================
- Hits 49368 49367 -1
- Misses 2131 2132 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Lets see if this breaks anything -- shouldnt actually be used anywhere except maybe tests
Differential Revision: D67413011