Combine experiment and gs fields into AnalysisBase #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66712036 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 3, 2024
Summary: AnalysisBase will have optional `_experiment` and `_generation_strategy` fields, with getter and setter properties, as well as the `standard_generation_strategy` prop from `Scheduler`. `Scheduler` and `AxClient` will inherit these from it. The naming is less than optimal with AnalysisBase holding the experiment and GS. This is otherwise a no-op change designed to reduce pyre errors. Differential Revision: D66712036
danielcohenlive
force-pushed
the
export-D66712036
branch
from
63ada26 to
9bf3507
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66712036 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 498 499 +1
Lines 50518 50536 +18
=======================================
+ Hits 48388 48406 +18
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 5, 2024
Summary: AnalysisBase will have optional `_experiment` and `_generation_strategy` fields, with getter and setter properties, as well as the `standard_generation_strategy` prop from `Scheduler`. `Scheduler` and `AxClient` will inherit these from it. The naming is less than optimal with AnalysisBase holding the experiment and GS. This is otherwise a no-op change designed to reduce pyre errors. Differential Revision: D66712036
danielcohenlive
force-pushed
the
export-D66712036
branch
from
9bf3507 to
64a8119
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66712036 |
added 2 commits
December 5, 2024 13:51
Summary: This will allow us to also use clients to generate analyses. Reviewed By: jelena-markovic Differential Revision: D66706329
Summary: AnalysisBase will have optional `_experiment` and `_generation_strategy` fields, with getter and setter properties, as well as the `standard_generation_strategy` prop from `Scheduler`. `Scheduler` and `AxClient` will inherit these from it. The naming is less than optimal with AnalysisBase holding the experiment and GS. This is otherwise a no-op change designed to reduce pyre errors. Differential Revision: D66712036
danielcohenlive
force-pushed
the
export-D66712036
branch
from
64a8119 to
8eb3e55
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66712036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AnalysisBase will have optional
_experimentand_generation_strategyfields, with getter and setter properties, as well as thestandard_generation_strategyprop fromScheduler.SchedulerandAxClientwill inherit these from it.The naming is less than optimal with AnalysisBase holding the experiment and GS.
This is otherwise a no-op change designed to reduce pyre errors.
Differential Revision: D66712036