Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move estimate...savings to respective Strategy base classes #3056

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paschai
Copy link
Contributor

@paschai paschai commented Nov 12, 2024

Differential Revision: D65831213

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65831213

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (6e93124) to head (2bfcb7a).

Files with missing lines Patch % Lines
ax/early_stopping/strategies/base.py 66.66% 4 Missing ⚠️
ax/early_stopping/tests/test_strategies.py 85.71% 1 Missing ⚠️
ax/global_stopping/strategies/base.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
- Coverage   95.68%   95.67%   -0.01%     
==========================================
  Files         485      485              
  Lines       49297    49312      +15     
==========================================
+ Hits        47169    47180      +11     
- Misses       2128     2132       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants