sched-rr: A round-robin scheduler for normal thread #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a round-robin scheduler implement for normal thread (user-thread) create by pager or pthread lib, and using timeslice, we can prevent user-space thread starvation trigger by busy loop. This scheduler only schedling user thread create by ipc "thread start protocal". Default timeslice is 4096 ticks for now. Other trivial change: - Update defconfing for all board - Add sched-rr into Makefile - Add new config in kernel/Kconfig for setting thread timeslice
jserv
reviewed
Oct 10, 2016
| @@ -46,6 +46,7 @@ includes = \ | |||
| board/$(BOARD) \ | |||
| include \ | |||
| include/platform \ | |||
| include/sched-rr \ | |||
There was a problem hiding this comment.
Don't name it after sched-rr. Instead, use include/sched and manipulate each scheduling policy through dedicated file.
| @@ -93,6 +96,7 @@ loader-all-y += $(call objs_from_dir,kernel,loader-kernel) | |||
|
|
|||
| dirs = \ | |||
| kernel/lib \ | |||
| kernel/sched-rr \ | |||
| @@ -16,6 +16,7 @@ | |||
| #include <user-log.h> | |||
| #include <ktimer.h> | |||
| #include <interrupt.h> | |||
| #include <sched-rr/sched_rr.h> | |||
| #include <types.h> | ||
| #include <thread.h> | ||
| #include <ktimer.h> | ||
| #include <sched-rr/sched_rr.h> |
| @@ -12,6 +12,7 @@ | |||
| #include <platform/armv7m.h> | |||
| #include <fpage_impl.h> | |||
| #include <init_hook.h> | |||
| #include <sched-rr/sched_rr.h> | |||
| @@ -411,6 +412,9 @@ static tcb_t *thread_select(tcb_t *parent) | |||
| if (thr == NULL) | |||
| return NULL; | |||
|
|
|||
| if ((thr = rr_select()) != NULL) | |||
There was a problem hiding this comment.
Please make scheduling policy pluggable as Linux kernel does.
There was a problem hiding this comment.
Is like insmod/rmmod or config in make config?
Thanks.
Also, Linux kernel scheduler is pluggable!? Ain't they choose when config?
There was a problem hiding this comment.
OMg is pluggable....since 2004!
There was a problem hiding this comment.
I meant pluggable scheduler framework.
There was a problem hiding this comment.
If rr_select returns NULL, thrwill be modified as NULL and unexpected result
will happen in the following code.
jserv
reviewed
Oct 10, 2016
| @@ -71,6 +71,10 @@ menu "Thread tweaks" | |||
| config INTR_THREAD_MAX | |||
| int "Maximum of interrupt threads" | |||
| default 256 | |||
|
|
|||
| config THREAD_TIME_SLICE | |||
| int "Maximum timeslice for threads" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a round-robin scheduler implement for normal thread (user-thread)
create by pager or pthread lib, and using timeslice, we can prevent user-space
thread starvation trigger by busy loop.
This scheduler only schedling user thread create by ipc "thread start protocal".
Default timeslice is 4096 ticks for now.
Other trivial change: