Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default *.brep config files #1546

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

NWc0de
Copy link
Contributor

@NWc0de NWc0de commented Jul 20, 2024

Fixing Brep Configuraiton Files

Cut a branch from status of https://github.com/f3d-app/f3d on July 19 2024, 4:45PM PST.

C:\dev\f3d\src>git status
On branch fix_brep_default_config
nothing to commit, working tree clean

C:\dev\f3d\src>git log
Author: Mathieu Westphal <[email protected]>
Date:   Tue Jul 16 08:32:29 2024 +0200

    CI: Use VTK 9.3.1 in CI (#1542)

Default settings for a test .brep file were not respected in either the application's main window nor the thumbnail functionality on Windows

Application

BrepTestOne

Thumbnail

BrepTestTwo

After

commit 9770dd3a20e628e719609c2a8e12bd2031f50298 (HEAD -> fix_brep_default_config)
Author: Spencer Little <[email protected]>
Date:   Fri Jul 19 17:57:27 2024 -0700

    Add default *.brep config files

default settings for test .brep file were respected in both the application's main window and thumbnail

Application

BrepDefaultFixedApp

Thumbnail

BrepDefaultFixedThumbnail

@Meakk Meakk merged commit ce8dc9d into f3d-app:master Jul 20, 2024
39 checks passed
@Meakk
Copy link
Contributor

Meakk commented Jul 20, 2024

Thanks @NWc0de !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants