Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering is flipped (UD) #125

Open
hzheng40 opened this issue Apr 5, 2024 · 1 comment · May be fixed by #133
Open

Rendering is flipped (UD) #125

hzheng40 opened this issue Apr 5, 2024 · 1 comment · May be fixed by #133
Assignees
@hzheng40 @luigiberducci

Comments

@hzheng40
Copy link
Member

hzheng40 commented Apr 5, 2024

Rendering is flipped upside down around the x-axis.

(top left origin vs bottom left origin)
@luigiberducci
Copy link
Collaborator

The rendering is fixed. Now the y-coordinate is updated accordingly.

However, there are wrong collisions detected along the track. It seems that removing the transpose (see map loading in track.py) messes up with the edt used in the scan computation.

@hzheng40 can you have a look?
It seems the transpose was already in the old gym (see set_map in main branch). So I guess the scan computation was relying on that somehow.

This was referenced May 3, 2024
Closed
Open
@luigiberducci luigiberducci linked a pull request May 3, 2024 that will close this issue
Open
@luigiberducci luigiberducci linked a pull request May 3, 2024 that will close this issue
125 rendering is flipped ud #133
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hzheng40 hzheng40

@luigiberducci luigiberducci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

125 rendering is flipped ud f1tenth/f1tenth_gym
2 participants
@hzheng40 @luigiberducci