Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default option for fallback theme #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Odilf
Copy link

@Odilf Odilf commented Aug 4, 2024

This PR adds a default option that is used in case the system theme is not detected (before it got set to light mode, which I suspect is not usually the desired behaviour). This only applies to Linux since, afaict, macOS and Windows always have some option enabled.

This is useful in desktop-less environments (e.g., a server) and some linux environments (e.g., it was unclear to me how to set it up in Hyprland).

In my case, I was using this plugin on my macOS setup and it worked perfectly, then I tried it on a server to edit files locally and it blasted me with light mode so I had to disable it. Then I installed Linux with Hyprland and it was hard to figure out how to set the xorg setting, so I had to also disable it there. This PR will hopefully help with neovim setups that work consistently across the board! 😁

The default option name might need a bit of bikeshedding. Potential alternatives are default_theme (which I don’t particularly like) and fallback (which I do like). Feel free to use whichever you prefer :)

Also, docs need to be written and perhaps the README needs to be updated. However, I'm not sure exactly where they would go since there is not the usual "configuration" section in neither.

@f-person
Copy link
Owner

f-person commented Aug 5, 2024

Thanks, nice stuff! I like fallback better too, could you change it? :)

@Odilf
Copy link
Author

Odilf commented Aug 5, 2024

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants