fix _sendAsync canceler #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpProvider.prototype.sendAsync returns undefined so we can't cancel it. https://github.com/ethereum/web3.js/blob/develop/lib/web3/httpprovider.js#L114-L141
|
let's wait for answer on purescript-contrib/purescript-aff#148 before we merge |
|
We can merge this so killFiber is not blowing up, and then once web3/web3.js#1618 is merged we can implement proper canceler which aborts running ajax request |
|
Note it would be harder for metamask to support cancellation see MetaMask/metamask-extension#4225, so we should have in mind that sendAsync might return undefined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpProvider.prototype.sendAsync returns undefined so we can't cancel it.
https://github.com/ethereum/web3.js/blob/develop/lib/web3/httpprovider.js#L114-L141